fix(fix-163): fix tv_umur0 calculation #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgavignet
requested review from
michaeldesigaud,
fperinel and
jzck
and removed request for
michaeldesigaud
trecouvr
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Je me demande si ça ne va pas faire bugger les match pour les tvs coef_reduction_deperdition et generateur_combustion.
https://github.com/jzck/Open3CL/blob/main/src/3.1_b.js#L60-L81
https://github.com/jzck/Open3CL/blob/main/src/13.2_generateur_combustion.js#L15
Peut etre qu'il faudrait mieux utiliser le meme procéder que ces deux matchers plutot que de modifier la fonction tvMatch ?
michaeldesigaud
approved these changes
Nov 5, 2024
|
@trecouvr l'idée c'est d'alléger un maximum le temps d'exécution de la lib notamment sur les matcher. Parcourir les éléments et faire des evals plusieurs fois est consommateur. J'ai ajouté un Number.isInteger(match_value) pour être sur de ne pas faire de régression sur les parties combustion (qui seront revue un peu avec #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #163