Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented EditUserText api request. #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maxchehab
Copy link

I have implemented the /api/editusertext POST request.

To access this feature create an OAuthSession and...

submission, err := session.EditUserText(geddit.NewEdit("this is an edit", "t3_7pni8t"))

😄

@jzelinskie
Copy link
Owner

Genuine question here -- I've previously been avoiding passing around thing_ids as pure strings, but rather forcing users to query the API and then have an some kind of API object that implements a private method to get the ID (e.g. voter, deleter). Do people prefer this type safety or do you just want stringly typed access to the API?

@maxchehab
Copy link
Author

I think that since the library is not complete it is best to give the user as much access to the raw input. As you start to finish the library these features can of course be depreciated.

Just my two cents.
😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants