Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kind dsn leakage #4271

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix kind dsn leakage #4271

merged 1 commit into from
Apr 11, 2024

Conversation

makhov
Copy link
Contributor

@makhov makhov commented Apr 11, 2024

Description

Removes kine dsn from logs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@makhov
Fix kind dsn leakage
979857f 
Signed-off-by: Alexey Makhov <[email protected]>
@makhov makhov requested a review from a team as a code owner April 11, 2024 11:34
@makhov makhov requested review from ncopa, twz123 and jnummelin April 11, 2024 11:34
@makhov makhov added backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch labels Apr 11, 2024
twz123
twz123 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@twz123 twz123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it can contain credentials? Then we wanna backport this I guess? (ah, labels are there.)

@makhov makhov merged commit 52ef157 into k0sproject:main Apr 11, 2024
80 checks passed
@k0s-bot
Copy link

k0s-bot commented Apr 11, 2024

Successfully created backport PR for release-1.26:

@k0s-bot k0s-bot mentioned this pull request Apr 11, 2024
Merged
@k0s-bot
Copy link

k0s-bot commented Apr 11, 2024

Successfully created backport PR for release-1.27:

@k0s-bot k0s-bot mentioned this pull request Apr 11, 2024
Merged
@k0s-bot
Copy link

k0s-bot commented Apr 11, 2024

Successfully created backport PR for release-1.28:

This was referenced Apr 11, 2024
Merged
Merged
@k0s-bot
Copy link

k0s-bot commented Apr 11, 2024

Successfully created backport PR for release-1.29:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 twz123 approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin

Assignees
No one assigned
Labels
backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch security fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makhov @k0s-bot @twz123