Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid configuration in gitops-flux.md #5428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

osbre
Copy link

@osbre osbre commented Jan 10, 2025

Description

I was getting this error due to an invalid configuration. This PR fixes it.

 Deployment.apps "web-server" is invalid: [spec.template.metadata.labels: Invalid value: map[string]string(nil): selector does not match template labels, spec.template.spec.containers: Required value]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@osbre osbre requested review from a team as code owners January 10, 2025 17:51
@osbre osbre requested review from kke and twz123 January 10, 2025 17:51
@twz123
Copy link
Member

twz123 commented Jan 10, 2025

Thank you! Can you maybe sign-off your commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants