breaking: Fix fsys.OpenFile confusion of flags and permissions #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenFile used to accept
FileMode
twice, as in:The correct (or stdlib equivalent) signature is to accept an integer for the status flags and fs.FileMode for the permissions, as in:
The status flags are:
File access:
0x0
, you can pass a zero if you just want to read a file (this is whatfsys.Open
does and it should be used instead for that purpose.).File creation:
Usage:
The
rigfs.FileMode
was retired, you're now expected to use fs.FileMode from"io/fs"
.There were some other omissions and logical errors in the previous implementation of the function.