Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.23 bump #1379

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

bpickard22
Copy link

Bumps to go 1.23 and bumps deps

@coveralls
Copy link

coveralls commented Jan 21, 2025

Coverage Status

coverage: 55.735%. remained the same
when pulling 549b448 on bpickard22:master
into 4a0b507 on k8snetworkplumbingwg:master.

@dougbtv dougbtv changed the title Dep bumps Go 1.23 bump Jan 21, 2025
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just to make sure... it doesn't need any changes to the vendored files? e.g. in ./vendor right?

Log level env no longer exists

Signed-off-by: Benjamin Pickard <[email protected]>
Update all deps in go.mod

This commit will not build, I will fix the DRA issue in the next commit

Signed-off-by: Benjamin Pickard <[email protected]>
Claims are no longer associated with one class in kube 1.31

Signed-off-by: Benjamin Pickard <[email protected]>
@dougbtv
Copy link
Member

dougbtv commented Jan 22, 2025

Thanks for the DRA change... I don't fully grok it, so... I'm gonna file an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants