Add check for managed cap manager fn

pact-tests/Pact/Core/Test/TransitiveDependencyTests.hs

@@ -0,0 +1,13 @@
+module Pact.Core.Test.TransitiveDependencyTests where
+
+-- import Pact.Core.Names
+-- import Pact.Core.Hash
+
+-- fooModuleHash :: ModuleHash
+-- fooModuleHash = ModuleHash $ hash "foo"
+
+-- barModuleHash :: ModuleHash
+-- barModuleHash = ModuleHash $ hash "bar"
+
+-- bazModuleHash :: ModuleHash
+-- bazModuleHash = ModuleHash $ hash "baz"

pact-tests/constructor-tag-goldens/DesugarError.golden

@@ -24,4 +24,5 @@
 {"conName":"DuplicateDefinition","conIndex":"17"}
 {"conName":"InvalidBlessedHash","conIndex":"18"}
 {"conName":"InvalidNativeShadowing","conIndex":"19"}
+{"conName":"InvalidManagerFun","conIndex":"1a"}
 

pact-tests/pact-tests/db.repl

@@ -148,28 +148,6 @@
  "Module admin necessary for operation but has not been acquired:dbtest"
  (create-table persons2))
 
-;; test nested commits
-
-;  (begin-tx)
-;  (env-enable-repl-natives true)
-;  (module nested-tx G
-;    (defcap G () true)
-;    (defschema s x:integer)
-;    (deftable t:{s})
-;    (defun test-nested-tx ()
-;      (begin-tx)
-;      (insert t "a" { 'x: 1 })
-;      (commit-tx)
-;      (begin-tx)
-;      (insert t "b" { 'x: 2 })
-;      (rollback-tx)
-;      (expect "2nd insert rolled back" ["a"]
-;              (keys t))))
-
-;  (create-table t)
-;  (commit-tx)
-
-;  (nested-tx.test-nested-tx)
 
 ;; fold-db tests + key sort guarantees
 (env-exec-config [])

pact-tests/pact-tests/transitive.repl

@@ -97,4 +97,4 @@
 
 (begin-tx)
 (expect "calls-baz succeeds" 1 (baz.calls-baz))
-(commit-tx)
+(commit-tx)

pact-tng.cabal

@@ -597,5 +597,6 @@ test-suite core-tests
     , Pact.Core.Test.PactContinuationTest
     , Pact.Core.Test.ClientTests
     , Pact.Core.Test.ServerUtils
+    , Pact.Core.Test.TransitiveDependencyTests
   if (flag(with-crypto))
     build-depends: pact-tng:pact-crypto

pact/Pact/Core/Compile.hs

@@ -21,7 +21,6 @@ module Pact.Core.Compile
 
 import Control.Lens
 import Control.Monad
-import Control.Monad.State.Strict
 import Data.Text(Text)
 import Data.Maybe(mapMaybe)
 import Codec.Serialise(Serialise)

pact/Pact/Core/Errors.hs

@@ -344,6 +344,9 @@ data DesugarError
   | InvalidBlessedHash Text
   -- ^ Blessed hash has invalid format
   | InvalidNativeShadowing Text
+  -- ^ Name shadows an existing native
+  | InvalidManagerFun QualifiedName
+  -- ^ Manager function is an invalid ref
   deriving (Eq, Show,  Generic)
 
 instance NFData DesugarError
@@ -415,6 +418,8 @@ instance Pretty DesugarError where
       "Invalid blessed hash, incorrect format:" <+> pretty hs
     InvalidNativeShadowing t ->
       "Variable" <+> pretty t <+> "shadows native with the same name"
+    InvalidManagerFun qn ->
+      pretty qn <+> "is not a valid managed capability manager function." <+> pretty qn <+> "must be a defun"
 
 -- | Argument type mismatch meant for errors
 --   that does not force you to show the whole PactValue
@@ -1769,6 +1774,8 @@ desugarErrorToBoundedText = mkBoundedText . \case
       thsep ["Invalid blessed hash, incorrect format:", hs]
     InvalidNativeShadowing t ->
       thsep ["Variable", t, "shadows native with same name"]
+    InvalidManagerFun qn ->
+      thsep [renderQualName qn, "is not a valid managed capability manager function.", renderQualName qn, "must be a defun"]
 
 -- | NOTE: Do _not_ change this function post mainnet release just to improve an error.
 --  This will fork the chain, these messages will make it into outputs.

pact/Pact/Core/IR/Desugar.hs

@@ -59,6 +59,7 @@ import Pact.Core.Persistence hiding (loaded)
 import Pact.Core.Capabilities
 import Pact.Core.Errors
 import Pact.Core.IR.Term
+import Pact.Core.IR.Eval.Runtime.Utils
 import Pact.Core.Guards
 import Pact.Core.Imports
 import Pact.Core.Environment
@@ -1237,8 +1238,10 @@ resolveMeta _ DefEvent = pure DefEvent
 resolveMeta _ Unmanaged = pure Unmanaged
 resolveMeta _ (DefManaged AutoManagedMeta) = pure (DefManaged AutoManagedMeta)
 resolveMeta info (DefManaged (DefManagedMeta i (FQParsed pn))) = do
-  (name', _) <- resolveName info pn
+  (name', dk) <- resolveName info pn
   fqn <- expectedFree info name'
+  lift $ unlessExecutionFlagSet FlagDisablePact51 $ when (dk /= Just DKDefun) $
+    throwError $ PEDesugarError (InvalidManagerFun (fqnToQualName fqn)) info
   pure (DefManaged (DefManagedMeta i (FQName fqn)))
 
 expectedFree