Skip to content

Commit

Permalink
Make envFrom conditional to fix validation error (#22)
Browse files Browse the repository at this point in the history
Co-authored-by: German Osin <[email protected]>
Co-authored-by: Azat Safin <[email protected]>
  • Loading branch information
3 people authored Sep 10, 2024
1 parent 0d60015 commit 125f930
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/kafka-ui/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: kafka-ui
description: A Helm chart for kafka-UI
type: application
version: 1.4.3
version: 1.4.4
appVersion: v1.0.0
icon: https://raw.githubusercontent.com/kafbat/kafka-ui/main/documentation/images/logo_new.png
4 changes: 3 additions & 1 deletion charts/kafka-ui/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ spec:
name: {{ required "Missing required value envs.configMappings.[].name" $value.name }}
key: {{ required "Missing required value envs.configMappings.[].keyName" $value.keyName }}
{{- end }}
{{- if or .Values.existingConfigMap .Values.envs.config .Values.existingSecret .Values.envs.secret }}
envFrom:
{{- if .Values.existingConfigMap }}
- configMapRef:
Expand All @@ -94,7 +95,8 @@ spec:
{{- if .Values.envs.secret}}
- secretRef:
name: {{ include "kafka-ui.fullname" . }}
{{- end}}
{{- end}}
{{- end }}
ports:
- name: http
containerPort: 8080
Expand Down

0 comments on commit 125f930

Please sign in to comment.