Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Impl a default timeout for http requests #799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

o-afanasenko
Copy link

@o-afanasenko o-afanasenko commented Jan 22, 2025

What changes did you make? (Give an overview)
Added default timeout to HttpClient because without it some requests can never end, especially for high-load kafka connect.

For us this fixed problem when Kafka connectors page was infinitely in a loading state. Root cause is a kafka connect instance with Debezium connectors which sometimes doesn't respond. But this shouldn't block viewing of other connectors.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (see comment above)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@o-afanasenko o-afanasenko requested a review from a team as a code owner January 22, 2025 14:58
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 22, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi o-afanasenko! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Feb 3, 2025
@Haarolean Haarolean added this to the 1.2 milestone Feb 3, 2025
@Haarolean Haarolean changed the title Default timeout for http requests to prevent hanging BE: Impl a default timeout for http requests Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Status: PR Approved
Development

Successfully merging this pull request may close these issues.

2 participants