feat: persistent connections + improved connection handling

README.md

@@ -11,18 +11,23 @@ reconnect automatically, more features will be coming soon.
 Sample configuration for different services:
 ```yaml
 - name: "jaeger-ui"
-  # <deployment name>.<namespace>
+  # <service name>.<namespace>
   target: "simple-query.observability"
   ports:
     local: 8686    # Same port as remote since it's the UI standard port
     remote: 16686   # Jaeger UI default port
   options:
     retry_interval: 5s
-    max_retries: 30
+    # Max retries is optional and can be ignored if persistent_connection is set to true (defaults to 3 if missing)
+    # max_retries: 30
     health_check_interval: 10s
+    # This is true by default and it ignores max_retries
+    persistent_connection: false
   # local_dns:
   #   enabled: true
   #   hostname: "jaeger.localhost"  # Optional (it doesn't work yet), if you want to access it through a nice local domain
+  # Given the case that the service name matches the pod name then you don't need to use the pod_selector 
+  # to specify labels
   pod_selector:
     label: "app.kubernetes.io/instance=simple"
 

config.yaml

@@ -1,5 +1,5 @@
 - name: "jaeger-ui"
-  # <deployment name>.<namespace>
+  # <service name>.<namespace>
   target: "simple-query.observability"
   ports:
     local: 8686    # Same port as remote since it's the UI standard port
@@ -8,6 +8,8 @@
     retry_interval: 5s
     max_retries: 30
     health_check_interval: 10s
+    # This is true by default and ignores max_retries
+    persistent_connection: false
   # local_dns:
   #   enabled: true
   #   hostname: "jaeger.localhost"  # Optional (it doesn't work yet), if you want to access it through a nice local domain
@@ -21,8 +23,10 @@
     remote: 8080   # https
   options:
     retry_interval: 5s
-    max_retries: 30
+    # max_retries: 30
     health_check_interval: 10s
+    # This is true by default and ignores max_retries
+    persistent_connection: true
   # local_dns:
   #   enabled: true
   #   hostname: "argocd.localhost"  # Optional (it doesn't work yet), if you want to access it through a nice local domain

src/config.rs

@@ -26,6 +26,8 @@ pub struct ForwardOptions {
     pub retry_interval: Duration,
     #[serde(default = "default_max_retries")]
     pub max_retries: u32,
+    #[serde(default = "default_persistent_connection")]
+    pub persistent_connection: bool,
     #[serde(with = "humantime_serde", default = "default_health_check_interval")]
     pub health_check_interval: Duration,
 }
@@ -53,3 +55,7 @@ fn default_max_retries() -> u32 {
 fn default_health_check_interval() -> Duration {
     Duration::from_secs(10)
 }
+
+fn default_persistent_connection() -> bool {
+    true
+}