Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts bumps and windows removal #501

Closed
wants to merge 2 commits into from

Conversation

jimmykarily
Copy link
Contributor

Because the bump introduced a dependency to ghw library which resulted in an error when building a windows binary:

package github.com/kairos-io/provider-kairos/v2/cli/kairosctl
	imports github.com/kairos-io/provider-kairos/v2/internal/cli
	imports github.com/kairos-io/kairos-agent/v2/pkg/config
	imports github.com/kairos-io/kairos-agent/v2/pkg/utils/partitions
	imports github.com/jaypipes/ghw/pkg/linuxpath: build constraints exclude all Go files in /home/dimitris/go/pkg/mod/github.com/jaypipes/[email protected]/pkg/linuxpath

The right fix would be to extract the things we need from the kairos-agent to a separate package so that we don't depend on irrelevant libraries here. But for now, I'm just reverting the bump to be able to release.

@jimmykarily jimmykarily requested a review from a team December 13, 2023 08:19
@jimmykarily jimmykarily self-assigned this Dec 13, 2023
@jimmykarily jimmykarily force-pushed the reverts-bumps-and-windows-removal branch from a859aef to bc5238e Compare December 13, 2023 08:49
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6107788) 12.39% compared to head (bc5238e) 12.39%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   12.39%   12.39%           
=======================================
  Files          16       16           
  Lines        1065     1065           
=======================================
  Hits          132      132           
  Misses        906      906           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmykarily
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants