Skip to content

Commit

Permalink
feat(FEC-10347): expose kaltura player as a global variable instead o…
Browse files Browse the repository at this point in the history
…f UMD (#50)

set `libraryTarget:'var'` as default.
Change the externals to use the root only.

Solves FEC-10347

BREAKING CHANGE: kanalytics plugin is not UMD anymore
  • Loading branch information
yairans authored Aug 20, 2020
1 parent 2bebabb commit 28641f8
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ module.exports = {
path: __dirname + '/dist',
filename: '[name].js',
library: ['playkit', 'kanalytics'],
libraryTarget: 'umd',
umdNamedDefine: true,
devtoolModuleFilenameTemplate: './kanalytics/[resource-path]'
},
devtool: 'source-map',
Expand Down Expand Up @@ -61,17 +59,7 @@ module.exports = {
modules: [path.resolve(__dirname, 'src'), 'node_modules']
},
externals: {
'kaltura-player-js': {
commonjs: 'kaltura-player-js',
commonjs2: 'kaltura-player-js',
amd: 'kaltura-player-js',
root: ['KalturaPlayer']
},
'playkit-js-providers': {
commonjs: 'playkit-js-providers',
commonjs2: 'playkit-js-providers',
amd: 'playkit-js-providers',
root: ['KalturaPlayer', 'providers']
}
'kaltura-player-js': ['KalturaPlayer'],
'playkit-js-providers': ['KalturaPlayer', 'providers']
}
};

0 comments on commit 28641f8

Please sign in to comment.