-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a Goertzel filter instead of using the fft #51
base: master
Are you sure you want to change the base?
Conversation
What's the difference between the two invocations of minimodem in your example? |
Ops! Nothing, I pasted twice the same invocation. I edited the comment to fix that and added how I generated the audio |
@kamalmostafa I hope you have a chance soon to look at this :) |
@aguaviva Yes, your Goertzel implementation is quite interesting! I'll set aside some time to review this and respond soon. |
Awesome! I'll be happy to answer any questions you may have :) |
Thanks for this! @aguaviva please see my email reply. Test merge here, on the tmp/aguaviva-goertzel branch: commit da66d40 Merge to master pending resolution of rx "ampl=" test-case failures: https://github.com/kamalmostafa/minimodem/runs/3093947230 |
Hi @aguaviva -- Did you receive my email 2021-07-17 Subject: "minimodem Goertzel implementataion"? Please reply, or let me know here if you didn't. |
hey, I am going to look at things now. Sorry for the delay. |
hey @kamalmostafa, please consider my PR a proof of concept and feel free to refactor it in anyway you see fit. |
Any updates on this? |
There you go!
generating the audio:
decoding the audio:
This 'should' close #50 although this is just a quick implementation and I am sure you will want to refactor things a big
Also, note that that Goertzel function is returning the magnitude squared, I'd need a square root but it is not really necessary.
Thanks for this project though!