20240131 prt hmac

[Firstyear]

Supersedes/Incorporates #20, this improves our support for PRTv2 decryption as well as signing and verifying JWS messages with derived keys.

• [ x ] cargo fmt has been run
• [ x ] cargo test has been run and passes
• documentation has been updated with relevant examples (if relevant)

[dmulder]

You've also got some dead code:

warning: method `raw_key` is never used
  --> src/crypto/a256gcm.rs:30:19
   |
29 | impl JweA256GCMEncipher {
   | ----------------------- method in this implementation
30 |     pub(crate) fn raw_key(&self) -> [u8; KEY_LEN] {
   |                   ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: method `ms_oapxbc_key` is never used
   --> src/crypto/a256gcm.rs:120:19
    |
119 | impl JweA256GCMEncipher {
    | ----------------------- method in this implementation
120 |     pub(crate) fn ms_oapxbc_key(&self) -> &[u8] {
    |                   ^^^^^^^^^^^^^

warning: `compact_jwt` (lib) generated 2 warnings

[dmulder]

I built and ran it against Azure and the derived key signing works as expected :)

[dmulder]

You've also got some dead code:

warning: method `raw_key` is never used
  --> src/crypto/a256gcm.rs:30:19
   |
29 | impl JweA256GCMEncipher {
   | ----------------------- method in this implementation
30 |     pub(crate) fn raw_key(&self) -> [u8; KEY_LEN] {
   |                   ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: method `ms_oapxbc_key` is never used
   --> src/crypto/a256gcm.rs:120:19
    |
119 | impl JweA256GCMEncipher {
    | ----------------------- method in this implementation
120 |     pub(crate) fn ms_oapxbc_key(&self) -> &[u8] {
    |                   ^^^^^^^^^^^^^

warning: `compact_jwt` (lib) generated 2 warnings

Well, that's odd. I can see raw_key is used by begin_rsa_oaep_key_agreement, which is a public function. That warning doesn't make sense. ms_oapxbc_key on the other hand clearly isn't used anywhere.

[Firstyear]

Sorry about that, I accidentally disabled warnings and forget to re-enable them. Re-tested with the various feature combinations, and it works now. Also addressed your other comments.

[dmulder]

LGTM