Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorUtils refactor and test coverage + minor fixes #684

Merged
merged 9 commits into from
Oct 12, 2024

Conversation

gitoak
Copy link
Contributor

@gitoak gitoak commented Oct 12, 2024

Pull request

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Did you lint your code locally before submission?
  2. Did you test your feature thoroughly to ensure there are no bugs?
  3. Does your feature introduce breaking changes?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Please describe your changes

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Describe what your code exactly does and if it affects any other part of the code in any way (especially check for breaking changes)

Additional context

  • Rewrote colorUtils.js to ts with more robust input validation
  • Minor fixes in getContrast()
  • solid test coverage for colorUtils.ts
  • updated eslint config to fix eslint error for typing functions
  • bumbed typescript version

utils/colorUtils.spec.ts Dismissed Show resolved Hide resolved
@trobonox trobonox merged commit 9216b92 into kanriapp:main Oct 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants