Fix/draw tile objects

[wolf81]

Fix drawing tile objects in isometric projection.

Please note this is not a perfect fix, but the result is much closer to what is shown in Tiled. A small offset seems to be required perfectly position the tile objects, but as of not I'm not really sure how this offset should be calculated. Also other objects (e.g. rectangles) in object layer seem to need some small adjustments in order for them to be shown in the proper position (however this PR only focuses on tile objects in object layers in isometric projection).

[wolf81]

I should add that the following code improves the isometric drawing even more, but I am not 100% sure if this approach is valid always, so the following code is not (yet) part of the PR.

function Map:setObjectCoordinates(layer)
   -- ...
	elseif object.shape == "rectangle" and object.gid then -- a tile object
		if self.orientation == "isometric" then
			object.x, object.y = utils.convert_isometric_to_screen(
				self, 
				object.x + self.tileheight * 2 + w / 2, 
				object.y + self.tileheight * 2
			)
		end
	end
   -- ...
end

In the above code I am not really sure why I need to add self.tileheight * 2 in order for the x and y positions to be drawn properly, which is why I didn't add that code to the PR. But locally (on my machine) I use this approach right now. However this comment also does some tile position modification and that's probably in some way related to the above fix.

By the way, this PR might fix the issues mentioned here, but not 100% sure:

• Isometric coordinates not generating automatically #148
• Object positions aren't correct for isometric maps. #242

[karai17]

Could you provide a few test maps that show this code fix working in various cases? screenshots are fine~

…

--- Landon Manning [email protected]

On Thu, 21 Jan 2021 at 23:09, Wolfgang Schreurs ***@***.***> wrote: I should add that the following code improves the isometric drawing even more, but I am not 100% sure if this is approach is valid always, so I haven't pushed it. function Map:setObjectCoordinates(layer) for _, object in ipairs(layer.objects) do -- etc ... if object.shape == "rectangle" and not object.gid then -- etc ... elseif object.shape == "rectangle" and object.gid then -- a tile object if self.orientation == "isometric" then object.x, object.y = utils.convert_isometric_to_screen(self, object.x + self.tileheight * 2 + w / 2, object.y + self.tileheight * 2) end end end end — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#248 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEQD7ERFXU5OGH2H67IWODS3DT57ANCNFSM4WN2NGMQ> .

[wolf81]

Could you provide a few test maps that show this code fix working in various cases? screenshots are fine~
…

I'll try to add some examples tomorrow.