Hex coord conversion fix (and also EmmyLua comments) #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote this based off of the Tiled source code, as the original code was; didn't realize your code had already been based off of it, which is why mine looks different. I think it was just a couple minor things transitioning from C++ to Lua here, the distance-squared function and the offsets were a little off. Tested these functions extensively, they seem to work 100% fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a fix here to resolve the standing issues with converting tiles to pixels and vice versa. I similarly pulled the math from Tiled's source, but made a few changes that seem to fix the issues. Notably, Tiled uses (0,0) as the origin, while STI assumed it was (1,1). The two functions - convertPixelToTile and vice versa - treat origin like (0,0), but I haven't adjusted that for the other grid types. You can either just adjust the math by +1 for my code, or adjust the origin to (0,0), doesn't matter.
Tested this quite a bit, seems to work fine. I didn't get a chance to confirm it with an isometric staggered tile set, may want to do that.
I also included EmmyLua comments, in a separate commit. I wrote those for my own sake but feel free to merge them in, it helped me pick up the API quicker.
#113 <- fix for this