fix: make Transaction.from_raw() able to parse unsigned segwit tx #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although Transaction.from_raw() is able to parse a signed or unsigned legacy tx, it is only able to correctly parse signed segwit txs because it assumes the presence of witnesses in the tx payload. But unsigned segwit tx payload do not have any witness. This PR proposes to fix that by checking the number of remaining bytes between the end of the last output and the end of the payload and by skipping the witnesses parsing if that number is not greater than 4 (locktime field length).
hcleonis
force-pushed
the
fix/witness-parsing
branch
from
fe6e3c5 to
222824e
Compare
|
Hi @hcleonis ! Looks good. Can you add a test (in tests) with the example you used to test it? I will then review and merge. Thank you |
Great! I'm on something else right now but I'll do that as soon as I can. |
|
Great job, thank you for fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
Transaction.from_raw()is able to parse a signed or unsigned legacy tx, it is only able to correctly parse signed segwit txs because it assumes the presence of witnesses in the tx payload.But unsigned segwit tx payloads do not have any witness field.
This PR proposes to fix that by checking the number of remaining bytes between the end of the last output and the end of the tx payload and by skipping the witnesses parsing if that number is not greater than 4 (i.e. last tx field i.e.
locktimelength).