refactor: show planned path in enum class changes for maintainer review

[dksmiffs]

Work started on #22, this draft intended for early maintainer feedback on approach.

[codecov]

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 32.10%. Comparing base (a025929) to head (197acba).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
src/PDU/Information_Operations/IO_Action_PDU.cpp	0.00%	12 Missing ⚠️
src/DataTypes/IOEffect.cpp	8.33%	11 Missing ⚠️
src/DataTypes/StandardVariable.cpp	0.00%	5 Missing ⚠️
src/PDU/Information_Operations/IO_Report_PDU.cpp	0.00%	4 Missing ⚠️
src/DataTypes/IOCommunicationsNode.cpp	25.00%	3 Missing ⚠️
include/KDIS/DataTypes/FactoryDecoder.hpp	0.00%	1 Missing ⚠️
src/DataTypes/DEAreaAimpoint.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   32.11%   32.10%   -0.02%     
==========================================
  Files         290      290              
  Lines       27470    27483      +13     
  Branches     1125     1125              
==========================================
  Hits         8823     8823              
- Misses      18647    18660      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[carlocorradini]

@dksmiffs I would also add the type to the enum class if mapping to a known DIS type (and therefore knowing the maximum number of elements):

enum class Example : std::uint8_t {
  // ...
}

[dksmiffs]

@carlocorradini - in 6fb761f, please note line 99 in src/DataTypes/StandardVariable.cpp. I'd like your feedback on what I should do there. StandardVariableType is a KUINT32 enum, but FactoryDecode takes a KINT32. I obviously don't like that code the way I have it written.

Update: see 197acba below for my proposed fix to this issue.

[karljj1]

Very nice. Thanks!

[carlocorradini]

@carlocorradini - in 6fb761f, please note line 99 in src/DataTypes/StandardVariable.cpp. I'd like your feedback on what I should do there. StandardVariableType is a KUINT32 enum, but FactoryDecode takes a KINT32. I obviously don't like that code the way I have it written.

Update: see 197acba below for my proposed fix to this issue.

Because the generic represents the underlying type of an enum, why not set KUINT32 as the default value? What do you think?
Furthermore, what do you think if we take directly the enum type (rather than the primitive underlying type) as generic and use a combination of std::is_enum (static assertion that the generic is an enum) and std::underlying_type?

[dksmiffs]

Sounds good, @carlocorradini.