Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin github action runner to ubuntu-22.04 not the latest #167

Merged

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Jan 16, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Pin Github runner to the official release, not the latest.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The latest release might break our tests unexpectedly because the software installation might be different between releases.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 16, 2025
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2025
@RainbowMango
Copy link
Member Author

cc @warjiang @samzong

@warjiang
Copy link
Contributor

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@karmada-bot karmada-bot merged commit a8c9b9e into karmada-io:main Jan 17, 2025
6 checks passed
@RainbowMango RainbowMango deleted the pr_pin_github_runner_to_ubuntu-22.04 branch January 17, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants