feat: add capitalize and titleCase method for i18n #168
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/M
| @@ -21,7 +21,9 @@ const Overview = () => { | |||
| }, | |||
| { | |||
| key: 'karmada-status', | |||
| label: i18nInstance.t('3fea7ca76cdece641436d7ab0d02ab1b', '状态'), | |||
| label: capitalize( | |||
There was a problem hiding this comment.
Shall we always use title case?
There was a problem hiding this comment.
+1, for this case capitalize and titleCase method share the same effect, but titleCase is more suitable.
Signed-off-by: warjiang <[email protected]>
…tleCase Signed-off-by: warjiang <[email protected]>
… switcher Signed-off-by: warjiang <[email protected]>
karmada-bot
added
do-not-merge/contains-merge-commits
warjiang
force-pushed
the
feat/i18n-translation
branch
2 times, most recently
from
2075e7a to
a645653
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
|
/assign @RainbowMango @samzong |
Signed-off-by: warjiang <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
It seems unnecessary to handle it like this. recommended to correct the i18n text, otherwise, this part of the code logic will confuse users; Additionally, will there be any issues when concatenating prompt words?
What type of PR is this?
/kind feature
What this PR does / why we need it:
1. capitalize or titleCase for some special usages.
2. set english as default language.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: