chore: format code about exported function should have comment

[chaosi-zju]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

chore: format code about exported function should have comment

Which issue(s) this PR fixes:

Fixes part of karmada-io/karmada#6078

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[chaosi-zju]

@seanlaii thanks for reviewing

besides, here may still be some revive type error other than exported function should have comment, would you like to continue to handle those revive type lint error?

so sorry that I tagged the wrong person !

[chaosi-zju]

@warjiang thanks for reviewing

besides, here may still be some revive type error other than exported function should have comment, would you like to continue to handle those revive type lint error?

[warjiang]

@warjiang thanks for reviewing

besides, here may still be some revive type error other than exported function should have comment, would you like to continue to handle those revive type lint error?

glad to handle kind of lint errors reported by revive, may be we can split the huge task into small tasks,

dashboard/.golangci.yml

Lines 54 to 85 in 5648666

	revive:
	rules:
	# Disable if-return as it is too strict and not always useful.
	# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#if-return
	- name: if-return
	disabled: true
	- name: package-comments
	- name: superfluous-else
	arguments:
	- preserveScope
	- name: error-strings
	- name: error-return
	- name: receiver-naming
	- name: increment-decrement
	- name: range
	- name: error-naming
	- name: dot-imports
	- name: errorf
	- name: exported
	- name: var-declaration
	- name: blank-imports
	- name: indent-error-flow
	- name: unreachable-code
	- name: var-naming
	- name: redefines-builtin-id
	- name: unused-parameter
	- name: context-as-argument
	- name: context-keys-type
	- name: unexported-return
	- name: time-naming
	- name: empty-block

like splitting task by rule name

[chaosi-zju]

like splitting task by rule name

good advice !

[warjiang]

/assign

[warjiang]

I've just reviewed the PR, a great deal of contributions 🔥

[chaosi-zju]

@warjiang is the failed CI build-frontend related to this PR?

[warjiang]

@warjiang is the failed CI build-frontend related to this PR?

I'm checking the build log, wait for a while~

[warjiang]

@swc/core installed failed, not caused by this PR,

and the following build command failed too.

I think maybe something wrong with github action network, because I check the code in my local enviroment and in github codebase environment twice, the next is the screenshot of github codebase, the enviroment should be clean as the github action ci:

@chaosi-zju can you retry to run the build-frontend job again.

[warjiang]

/retest

[chaosi-zju]

still failed

[warjiang]

still failed

em, I metioned that the some updates of @swc/core a day ago, i'll solved the build problem

[warjiang]

I can reproduce the problem 😭

npm install -g [email protected] 
pnpm install 
pnpm run build

and the error occurs:

log @karmada/dashboard:build: cache miss, executing 7cb8028c72204dfd indicates that pnpm-lock.yaml not compatible with pnpm in github ci.

log in github ci can also prove that:

if pnpm ignore pnpm-lock file, the default behaviour of pnpm is that the pnpm will ignore pnpm cache and install the latest dependencies. It seems something wrong between vite and the latest @swc/core package, and it will cause the ci build error.

the solution is just upgrade the pnpm version in the ci.yml file, and I just submit the pr to solve the problem

[warjiang]

BTW, the ci in the forked repo is ok

[warjiang]

/reopen

[karmada-bot]

@warjiang: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[warjiang]

@chaosi-zju sorry for close this pr by bot, can you rebase main branch？

[chaosi-zju]

done, comments fixed~

[warjiang]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [warjiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment