Token authentication 3rd party api #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ketankartoza Just want to check in and make sure you're aware this section needs to be changed as the URL is no longer the correct way to have a token generated
|
|
@EliVolsch, I am going to change the documentation for the token. I will open a PR for it today thanks!! |
ketankartoza
force-pushed
the
Token-authentication-3rd-party-api
branch
from
52f25fa to
c9b56da
Compare
amyburness
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
LGTM
@tinashechiraya @EliVolsch let me know if you have any comments otherwise I will merge this asap
|
@amyburness looks good to me |
ketankartoza
force-pushed
the
Token-authentication-3rd-party-api
branch
from
c9b56da to
a79d820
Compare
Jenkins Build Details:Build status: SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the issue #1097