Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WRS to 0.8.0 and async_channel to 2.0.0 #302

Closed
wants to merge 1 commit into from

Conversation

aspect
Copy link
Collaborator

@aspect aspect commented Oct 28, 2023

This PR updates workflow-rs to 0.8.0 to enable accept() functionality in wRPC needed for the file descriptor budget pool being implemented in #284

As workflow-rs updates the async_channel dependency to 2.0.0, it is also updated.

@@ -291,7 +304,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "62565bb4402e926b29953c785397c6dc0391b7b446e45008b0049eb43cec6f5d"
dependencies = [
"async-attributes",
"async-channel",
"async-channel 1.9.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do some of the references in this lock refer to 1.9.0 and why some 2.0.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async_std still uses an old version of async_channel and is thus a dependency of the project, however we make it a point that we use async_channel everywhere directly (I actually went over the code and corrected this where it was not so).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add: we can’t use same crates with different versions in any code that builds to WASM as wasm-pack will error out with naming collisions. To make sure this doesn’t occur by an accident, we have /test script build WASM after running tests. (and CI itself builds WASM as a separate stage). So the noted dependency is benign.

@aspect
Copy link
Collaborator Author

aspect commented Oct 30, 2023

Closing as same changes are coming in with #303 and #305.

@aspect aspect closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants