Remove File Descriptor init on Windows #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We discovered that windows max fd value is 8192. Prepping another PR to handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that instead of gracefully handling errors, on Windows
fdlimitis causing a crash resulting in the daemon halting withbuffer overflowerror without any kind of a panic, even settingRUST_BACKTRACE=1is not helping. With the help of@Callidonon Discord #development we narrowed it down to the changes in #333. In this PR I've isolated the code to run on MacOS and Linux only (as me and @biryukovmaxim have tested it on these platforms manually).