gRPC bandwidth tracking #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biryukovmaxim
suggested changes
Dec 2, 2023
biryukovmaxim
approved these changes
Dec 2, 2023
…tower in /utils/tower and rename connection counters to TowerConnectionCounters
tiram88
requested changes
Dec 10, 2023
tiram88
previously approved these changes
Dec 10, 2023
tiram88
approved these changes
Dec 10, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* grpc bandwidth tracking * split module into 'hyper' and 'grpc' * migrate gRPC connection counters and tower middleware to kaspa-utils-tower in /utils/tower and rename connection counters to TowerConnectionCounters * sort dependencies * sort dependencies * update naming & channel closure-related comment * remove not needed clone * rename to p2p_tower_counters and grpc_tower_counters * remove bincode from kaspa-utils dev-deps * fix sort in rpc/service * re-adding bincode due to failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring of #334 with a slightly reduced footprint. I went over #334 and carefully re-grafted only the changes specific to gRPC internals. @biryukovmaxim did excellent work building this.
Once this is merged I will be adding this to the upcoming PR that contains metrics refactoring.