More robust location definitions #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Say you had this Oaken seed file: ```ruby users.create :kasper, name: "Kasper" ``` We want `users.method(:kasper)` to point back to that file and line to help debugging. However, we had a hardcoded db/seeds in our detection, which meant that create/upsert/label in tests would fail on a NoMehodError because our `find` wouldn't return anything. In tests, labels make less sense in general, so I'm thinking we should allow those. I'm also thinking I should try to more sharply define the preparation phase versus the running phase. The preparation phase: loading and executing db/seeds.rb, setup defaults, helpers and common records The running phase: when running tests, you shouldn't mutate anything really, and labels shouldn't suddenly spring up, generally things should be deterministic. `Oaken.preparing?`/`Oaken.running?` may be on the table too. Note: this does get complicated if people are using `seed "cases/pagination"` with one-off seeds. Hm. Anyway, I'm detecting the path via a quirk on the label + our loading so we don't need to use `lookup_paths` at all. I'm not sure I'm liking any of this.
kaspth
force-pushed
the
more-robust-location-definitions
branch
from
b922f3d to
c81d9a5
Compare
kaspth
force-pushed
the
more-robust-location-definitions
branch
from
c3f15be to
2f7b4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say you had this Oaken seed file:
We want
users.method(:kasper)to point back to that file and line to help debugging.However, we had a hardcoded db/seeds in our detection, which meant that create/upsert/label in tests would fail on a NoMehodError because our
findwouldn't return anything.In tests, labels make less sense in general, so I'm thinking we should allow those.
I'm also thinking I should try to more sharply define the preparation phase versus the running phase.
The preparation phase: loading and executing db/seeds.rb, setup defaults, helpers and common records
The running phase: when running tests, you shouldn't mutate anything really, and labels shouldn't suddenly spring up, generally things should be deterministic.
Oaken.preparing?/Oaken.running?may be on the table too. Note: this does get complicated if people are usingseed "cases/pagination"with one-off seeds. Hm.Anyway, I'm detecting the path via a quirk on the label + our loading so we don't need to use
lookup_pathsat all. I'm not sure I'm liking any of this.