Skip to content

Commit

Permalink
docs: Remove mention of pullapprove
Browse files Browse the repository at this point in the history
Remove pullapprove from the contributors guide as we no longer use the
service.

Signed-off-by: James O. D. Hunt <[email protected]>
  • Loading branch information
jodh-intel committed May 24, 2019
1 parent a7ec16d commit 30508d4
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 14 deletions.
15 changes: 6 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -823,20 +823,17 @@ rejecting any PR. Although [anyone can review PRs](#reviews), only the
acknowledgement (or "ack") from an Approver counts towards the approval of a PR.
Approvers are listed in GitHub teams, one for each repository. The project
uses the [Pull Approve](https://PullApprove.com) service meaning each
repository contains a top level `.PullApprove.yml` configuration file. This
file lists the GitHub team used for that repository's approvals.
uses the
[GitHub required status checks](https://help.github.com/en/articles/enabling-required-status-checks)
along with the [GitHub `CODEOWNERS`
file](https://help.github.com/en/articles/about-code-owners) to specify who
can approve PRs. All repositories are configured to require:
Each repository can have custom review requirements but the minimum approval
requirements are:
- Two approvals from the approval team listed in the configuration file.
- Two approvals from the repository-specific approval team.
- One [documentation team](https://github.com/orgs/kata-containers/teams/documentation/members)
approval if the PR modifies documentation.
See the `.PullApprove.yml` configuration files for full details.
## Issue tracking
To report a bug that is not already documented, please open a GitHub issue for
Expand Down
9 changes: 4 additions & 5 deletions Documentation-Review-Process.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,9 @@ The following GitHub team lists the users who are members of the Documentation T
## Default document review process

[Project maintainers](https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#project-maintainers)
have the power to approve or reject PRs using the PullApprove tool employed by
all repositories.
have the power to approve or reject PRs.

If a Documentation Team review is required, the PullApprove configuration will
If a Documentation Team review is required, the `CODEOWNERS` configuration will
apply and the PR will be blocked until the required number of acks are
obtained for the documentation changes.

Expand Down Expand Up @@ -154,8 +153,8 @@ PTAL @kata-containers/documentation

1. Request a project maintainer force-merges the PR.

This operation bypasses the PullApprove check that normally stops a PR from
landing until the Documentation Team ack the PR.
This operation bypasses the check that normally stops a PR from
landing until the Documentation Team acks the PR.

1. The maintainer should notify the Documentation Team out of courtesy that
the PR has been merged.
Expand Down

0 comments on commit 30508d4

Please sign in to comment.