Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address a couple more UBSan warnings #350

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Address a couple more UBSan warnings #350

merged 7 commits into from
Apr 28, 2021

Conversation

silentbicycle
Copy link
Collaborator

  • Some of the hash functions weren't using SUPPRESS_EXPECTED_UNSIGNED_INTEGER_OVERFLOW().
  • Address more implicit conversions between signed / unsigned char.
  • Fix a possible underflow in ir.c.
  • Explicitly cast a negated flag.
  • Cast int to char in lx's generated code.

These don't address ALL the remaining warnings, but it eliminates quite a few of them.

@silentbicycle
Copy link
Collaborator Author

This CI failure should be addressed by #352.

@silentbicycle silentbicycle force-pushed the sv/remove-ubsan-warnings branch from 7e915f7 to 11efdb9 Compare April 28, 2021 20:27
@katef katef merged commit 7c18acb into main Apr 28, 2021
@katef katef deleted the sv/remove-ubsan-warnings branch April 28, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants