Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lx: Add a guard for referencing lx->end.col, may not be in the struct. #466

Merged
merged 1 commit into from
May 9, 2024
Merged

lx: Add a guard for referencing lx->end.col, may not be in the struct. #466

merged 1 commit into from
May 9, 2024

Conversation

silentbicycle
Copy link
Collaborator

This field doesn't exist when lx is called with -x pos, so don't include references to it the generated code.

@silentbicycle
lx: Add a guard for referencing lx->end.col, may not be in the struct.
1e07cc9 
This field doesn't exist when lx is called with `-x pos`, so don't
include references to it the generated code.
@silentbicycle silentbicycle requested a review from katef May 9, 2024 13:45
@silentbicycle
Copy link
Collaborator Author

This bug was introduced in 20ed256.

@katef katef merged commit f40c58a into main May 9, 2024
322 checks passed
@katef katef deleted the sv/lx-c-codegen-guard-api_pos-fields branch May 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katef katef katef approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silentbicycle @katef