-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
72 make legend box component #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Plots get names starting from f and following the alphabet - Plots get colors from a default list that cycles - Some styling Related to #72
- Add getName() function on Component class, which returns its ClassName if not defined to something else in the component itself and an empty string if component.name is not defined either - Components can have a displayText() function, which defines which text should be present in LegendBox - In the LegendBox, each row consists of <dot of plot color | black dot> + <component.name>. If displayText exists on component, this is displayed after <component.name> (ex. function expression for plots and coordinates for point) - Add emitter for Point, such that LegendBox updates when point is dragged around Related to #72
Related to #72
Related to #72
… on these variables in the legendBox (A draft that works, code must still be refined) Related to #72
Related to #72
Related to #72
jonasdeluna
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just fix the lint/prettier 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following information is currently configured to be displayed for the given element types:
<Plot name>
:<Plot expression>
<Point name>
:(x,y)
<State name>
:<State value>
<String with state variables>
:<String where state variables are replaced with actual current state values>
<Component ClassName>
Closes #72