Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

86 legendbox refinement #87

Merged
merged 10 commits into from
Aug 5, 2024
Merged

86 legendbox refinement #87

merged 10 commits into from
Aug 5, 2024

Conversation

amaliejvik
Copy link
Contributor

@amaliejvik amaliejvik commented Aug 2, 2024 •
edited
Loading

Make requested changes to LegendBox (and thereby Point):

  • Add 3 props to Point: "showName", "customName" and "legendCoordinates" such that user can give point a custom name, decide to show/hide the point name from grid and decide which coordinates to display in LegendBox (only x, only y or both)
  • Add prop to State: "inLegend" such that states can be used by expressions in LegendBox without being displayed as an own element in LegendBox
  • Fix that for Latex in LegendBox, only the expression with inserted values appears
  • Add LegendText object, such that user can add text in LegendBox with a custom icon and a custom color on the icon. Can depend on states declared if desired too.
Skjermbilde 2024-08-02 kl 16 53 03 Skjermbilde 2024-08-02 kl 16 53 36 Skjermbilde 2024-08-05 kl 15 23 09 image

Additionally: Add a bit padding to LegendBox wrapper such that it is a bit more space between upper-left corner and the box

Closes #86

@amaliejvik
When writing Latex in LegendBox, only the expression with inserted va…
f456723 
…lues appears

Related to #86
@amaliejvik
Add a bit space between LegendBox and the top/left
36cff3b
@amaliejvik
Add props to Point which give the ability to:
1fb574c 
- show/hide name from Points in the grid (showName)
- give Points custom names (customName)
- display only x or only y coordinates for points in LegendBox (legendCoordinates)

Related to #86
@amaliejvik
Make it possible to use States without them being displayed in LegendBox
3f272ea 
Related to #86
@amaliejvik amaliejvik self-assigned this Aug 2, 2024
@amaliejvik amaliejvik linked an issue Aug 2, 2024 that may be closed by this pull request
LegendBox refinement #86
Closed
@amaliejvik amaliejvik requested a review from jonasdeluna August 5, 2024 09:21
@amaliejvik
Create LegendText object
8a3a50e 
- LegendText replaces/extends the possibility of adding LaTex-strings to the LegendBox
- LegendText is initialized with an expression-string and some optionals: color for icon-color,  shape for icon-shape and useStates for deciding if the expression should listen to defined states

This gives more freedom and flexibility in adding text, LaTeX and the use of states in LegendBox

Related to #86
@amaliejvik
Lint fix and make spacing between LegendBox and top&left a bit smaller
6050cc7
@amaliejvik
Export LegendText in index.ts
4a35391
@amaliejvik amaliejvik merged commit 2e681ae into master Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasdeluna jonasdeluna jonasdeluna approved these changes

Assignees

@amaliejvik amaliejvik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LegendBox refinement
2 participants
@amaliejvik @jonasdeluna