perl-5.26.0 compatibility.

[jkeenan]

In Perl 5.26.0, '.' will no longer be found by default in @inc. This patch
adjusts Makefile.PL to accommodate that change.

For: https://rt.cpan.org/Ticket/Display.html?id=120737

[kentfredric]

Pretty much what I'd do. 👍

And it fixes the issues I'm aware of.

[moznion]

@jkeenan
IMO, it is prefer use FindBin; use lib $FindBin::Bin; rather than use lib '.';.
Because use lib '.'; handles relative path so there is a possibility to mix vulnerability. In other hand, use FindBin; use lib $FindBin::Bin; uses absolute path; so it is robust than other one.
(Though probably it is safe to use use lib '.'; on only Makefile.PL)

[kentfredric]

using . instead of anything else is more a result of what Module::Install does inside itself. Its a horror show. Module::Install augments @INC itself in a dozen or so ways on its own ( and it tweaks %INC! Ugh! )

For anything other than Module::Install I'd not use that use lib '.' syntax.

But for Module::Install, its about as close to a right answer as you'll get.

[jjn1056]

This has been outstanding for a while, for a module that is pretty upstream. I emailed author at his CPAN registered Email address but not sure if @kazuho is still monitoring or even working in Perl anymore.

[jkeenan]

This has been outstanding for a while, for a module that is pretty upstream. I emailed author at his CPAN registered Email address but not sure if @kazuho is still monitoring or even working in Perl anymore.

Yes, in these situations we often have to resort to trying to find someone who knows @kazuho IRL. In the version of CPAN-river which I calculated in June for reporting to P5P, this distribution was #350.

Fortunately, neither Catalyst-Runtime nor Catalyst-Devel is a revdep :-)