Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE-360 - create a release of orcidlink-enabled kbase-ui running under Europa #1663

Open
wants to merge 128 commits into
base: main3
Choose a base branch
from

Conversation

eapearson
Copy link
Contributor

Pull Request

In deploy iteration mode. Expect things to break for a couple days.

Description

  • Summarize the changes.
  • Describe relevant motivation and context.
  • List any dependencies involved in this change.

Issues Resolved

  • Added the Jira Tickets to the title of the PR e.g. (PTV-XXX fixes a terrible bug)
  • Added the Github Issue to the title of the PR e.g. (PTV-XXX adds an awesome feature)

Testing Instructions

Provide details for testing status and how to test the PR:

  • Tests pass locally
  • Tests pass in github actions
  • Manually verified that changes area available (by spinning up an instance and navigating to X to see Y)

Dev Checklist

  • Code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Integration tests have been run and fully pass (only when preparing a release)
  • I have run run the code quality script against the codebase (also done implicitly during a build)

Release Notes

  • Ensure there is an "upcoming release notes" file located in release-notes/RELEASE_NOTES_NEXT.md
  • Add relevant notes to this document

Release

This section only relevant if this PR is preparing a release

  • Bump version in config/release.yml
  • Rename release-notes/RELEASE_NOTES_NEXT.md to the appropriate release
  • Add release notes document to the release notes index release-notes/index.md

wip - not finished yet, but much in place.
the result of refactoring for Europa, fixing plugins, importing a few plugins into kbase-ui,
BASE_PATH->KBASE_UI_BASE_PATH, KBASE_UI_DOMAIN->KBASE_UI_HOSTNAME which defaults to "legacy"
it is a git safe-directory thing I've not seen before.
and generally improve the python tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant