apis/apis: clarify that binding.spec.reference.export is never nil b/…

…c validation

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

pkg/admission/apibinding/apibinding_admission.go

@@ -106,6 +106,7 @@ func (o *apiBindingAdmission) Admit(ctx context.Context, a admission.Attributes,
 	}
 
 	if apiBinding.Spec.Reference.Export == nil {
+		// should not happen due to validation.
 		return nil
 	}
 

pkg/admission/apibinding/validation.go

@@ -54,8 +54,7 @@ func ValidateAPIBindingUpdate(oldBinding, newBinding *apisv1alpha1.APIBinding) f
 // ValidateAPIBindingReference validates an APIBinding's BindingReference.
 func ValidateAPIBindingReference(reference apisv1alpha1.BindingReference, path *field.Path) field.ErrorList {
 	allErrs := field.ErrorList{}
-
-	// For now, field "export" is required via OpenAPI. But just in case...
+
 	if reference.Export == nil {
 		allErrs = append(allErrs, field.Required(path.Child("export"), ""))
 	} else if reference.Export.Name == "" {

pkg/reconciler/apis/apibinding/conflict_checker.go

@@ -72,11 +72,7 @@ func newConflictChecker(clusterName logicalcluster.Name,
 	}
 	for _, b := range bindings {
 		if b.Spec.Reference.Export == nil {
-			continue
-		}
-
-		if b.Spec.Reference.Export == nil {
-			// this should not happen because of OpenAPI
+			// this should not happen because of validation.
 			return nil, fmt.Errorf("APIBinding %s|%s has no cluster reference", logicalcluster.From(b), b.Name)
 		}
 		path := logicalcluster.NewPath(b.Spec.Reference.Export.Path)