🌱 reduce log verbosity for queueing operations #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
embik
approved these changes
Jan 22, 2024
|
LGTM label has been added. Git tree hash: 6eb878a74e9ccd568cfdc9624d0ddce18ab68c52
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/kind cleanup |
kcp-ci-bot
added
the
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces the log verbosity of many logging statements in kcp. I tried to debug something recently and the sheer amount of "processing key" and "queueing thing" messages that flew by made it difficult.
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md defines some guidance for log level usage and most importantly, queueing things should not be on level 1 (what i would consider the "panic" level). So I changed the levels to be
My hope is that running kcp with -v=2 should provide a nice log of things that actually change or break, and -v=4 being a nice log level for development.
Release Notes