🐛 Remove scope from initializingworkspaces virtual workspace #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
release-note-none
|
/lgtm |
|
LGTM label has been added. Git tree hash: 39086aa15908c5d1f6ca2fe6073684f74a31be71
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #3235, we added scoping to the impersonation that happens in the
initializingworkspacesvirtual workspace when proxying through content access. This creates a fundamental problem: When creatingAPIBindingsthrough it (a common activity done by kcp itself for the default API bindings in aWorkspaceType), the impersonated identity will always be out-of-scope for the workspace that holds the targetAPIExportfor a default binding.This means default API bindings would always be bound as
system:anonymous/system:authenticated(the identity of out-of-scope entities), which means you cannot properly provide permissions to the owner of a workspace (which is the identity impersonated by the virtual workspace).So for now we think we should undo the scoping in the virtual workspace.
Related issue(s)
Fixes #
Release Notes