🌱 Noop: Clean code and organize imports #3276
Conversation
Signed-off-by: Mangirdas Judeikis <[email protected]> On-behalf-of: @SAP [email protected]
kcp-ci-bot
added
release-note-none
| func (s *Server) addIndexersToInformers(ctx context.Context) map[schema.GroupVersionResource]replication.ReplicatedGVR { | ||
| permissionclaimlabel.InstallIndexers(s.KcpSharedInformerFactory.Apis().V1alpha1().APIExports(), s.KcpSharedInformerFactory.Apis().V1alpha1().APIBindings()) | ||
| permissionclaimlabler.InstallIndexers(s.KcpSharedInformerFactory.Apis().V1alpha1().APIExports()) | ||
| func (s *Server) addIndexersToInformers(_ context.Context) map[schema.GroupVersionResource]replication.ReplicatedGVR { |
There was a problem hiding this comment.
no change here, just \n and , added for readability.
|
/retest |
| @@ -320,7 +320,7 @@ func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numb | |||
| if i >= len(regions) { | |||
| break | |||
| } | |||
| patch := fmt.Sprintf(`{"metadata":{"labels":{"region":%q}}}`, regions[i]) | |||
| patch := fmt.Sprintf(`{"metadata":{"labels":{"region":%q,"shared": "true"}}}`, regions[i]) | |||
There was a problem hiding this comment.
just curious: why this? What does it mean?
There was a problem hiding this comment.
I'll need this for later. Allows us to have shared common label on framework share so you can target them to test the "label selector partition" (not wildcard one)
There was a problem hiding this comment.
now you get:
shard1:
region: foo
shard2:
region: bar
and this gives:
shard1:
region: foo
shared: true
shard2:
region: bar
shared: true
so you can target all
|
LGTM label has been added. Git tree hash: dea21cd3590898d17714f14568b440ffab7941ea
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Summary
No actual change is happening here. Just cleaning.
Related issue(s)
Fixes #
Release Notes