Pass alphaInfo from CGImage to CGContext during decompression #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytro-kasianchuk-doordash
force-pushed
the
dmytro-kasianchuk-doordash/fix-alpha
branch
from
7a52ff7 to
3e5e908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially transparent images sometimes are improperly rendered with decompression on. It's somewhat difficult to reproduce as it requires using partially transparent images and rendering multiple images at the same time.
It looks like Nuke is defaulting to CGAlphaInfo
.premultipliedLastwhich causes an issue. CGImage has Alpha information, passing it fixes the issue.