fix: make swap work when swapped items are arrays (ramda#3394)

kedashoe · Jul 28, 2023 · 165d2ae · 165d2ae
1 parent 6dd4ac9
commit 165d2ae
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/source/swap.js b/source/swap.js
@@ -33,9 +33,9 @@ var swapList = function(indexA, indexB, list) {
 
   result = []
     .concat(result.slice(0, positiveMin))
-    .concat(result[positiveMax])
+    .concat([result[positiveMax]])
     .concat(result.slice(positiveMin + 1, positiveMax))
-    .concat(result[positiveMin])
+    .concat([result[positiveMin]])
     .concat(result.slice(positiveMax + 1, length));
 
   return result;

diff --git a/test/swap.js b/test/swap.js
@@ -28,6 +28,10 @@ describe('swap', function() {
     eq(R.swap(0, 1, list), R.swap(1, 0, list));
   });
 
+  it('works with lists of arrays', function() {
+    eq(R.swap(0, -1, [['a', 'A'], ['b', 'B']]), [['b', 'B'], ['a', 'A']]);
+  });
+
   it('swaps property values from one property to another', function() {
     eq(R.swap('a', 'b', {a: 1, b: 2}), {a: 2, b: 1});
     eq(R.swap('b', 'a', {a: 1, b: 2}), {a: 2, b: 1});