ramda#3340: support empty path in modifyPath (ramda#3376)

kedashoe · Apr 25, 2023 · 241f811 · 241f811
1 parent de5803d
commit 241f811
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/source/modifyPath.js b/source/modifyPath.js
@@ -33,10 +33,14 @@ import _modify from './internal/_modify.js';
  *      R.modifyPath(['addresses', 0, 'zipCode'], R.reverse, person); //=> {name: 'James', addresses: [{ zipCode: '61209' }]}
  */
 var modifyPath = _curry3(function modifyPath(path, fn, object) {
-  if ((!_isObject(object) && !_isArray(object)) || path.length === 0) {
+  if (!_isObject(object) && !_isArray(object)) {
     return object;
   }
 
+  if (path.length === 0) {
+    return fn(object);
+  }
+
   var idx = path[0];
   if (!_has(idx, object)) {
     return object;

diff --git a/test/modifyPath.js b/test/modifyPath.js
@@ -24,6 +24,13 @@ describe('modifyPath', function() {
     assert.strictEqual(object, created);
   });
 
+  it('modifies the original object if path is empty array', function() {
+    var object  = {a: 'Tomato', b: { c: { d: [100, 101, 102] } }, e: { f: 'g', h: [1, 2, 3]  }};
+    var expected = {a: 'Tomato', b: 'Potato', e: { f: 'g', h: [1, 2, 3] }};
+    var created = R.modifyPath([], R.assoc('b', 'Potato'), object);
+    eq(created, expected);
+  });
+
   it('is not destructive', function() {
     var object   = {a: 'Tomato', b: { c: { d: [100, 101, 102] } }, e: { f: 'g', h: [1, 2, 3]  }};
     var expected = {a: 'Tomato', b: { c: { d: [100, 101, 102] } }, e: { f: 'g', h: [1, 2, 3]  }};