Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy lint error #4462

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix mypy lint error #4462

merged 1 commit into from
Feb 6, 2025

Conversation

ankatiyar
Copy link
Contributor

Description

Fix #4459 & #4460

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar ankatiyar requested a review from merelcht as a code owner February 6, 2025 10:54
@ankatiyar ankatiyar linked an issue Feb 6, 2025 that may be closed by this pull request
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankatiyar

@ankatiyar ankatiyar merged commit a064c46 into main Feb 6, 2025
35 checks passed
@ankatiyar ankatiyar deleted the fix-lint branch February 6, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Nightly build failure on develop ci: Nightly build failure on main
3 participants