This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 290
creating a local testnet with multiple nodes fails using only flags #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, you mean writing it to a JSON file and reading it back makes it work fine? can you debug the differences between in the spec in both the cases, this seems to be a hacky solution for now but its definitely progress and has some insights
@apoorvsadana @tdelabro can we merge this? |
tdelabro
suggested changes
Mar 5, 2024
@tdelabro can you check this? |
tdelabro
approved these changes
Mar 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Current behaviour is that genesis configuration hash changes upon each node instance. Therefore it is not possible to build a local testnet with multiple notes using only the cli flags.
I am not sure why the chainspec is not deterministic, could it be the wasm runtime?.
Resolves: #NA
What is the new behavior?
New behaviour is that it is possible to create a local testnet with multiple nodes using only cli flags as it just spits out the chainspec configuration into a json file and uses the same one.
Does this introduce a breaking change?
No
Other information