TODOs + issues

keep-starknet-strange · Feb 13, 2024 · 3c554a0 · 3c554a0
1 parent 6c00e39
commit 3c554a0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/appchain.cairo b/src/appchain.cairo
@@ -74,9 +74,9 @@ mod appchain {
         fn update_state(ref self: ContractState, program_output: Span<felt252>) {
             self.config.assert_only_owner_or_operator();
 
-            // TODO: reentrancy guard.
-            // TODO: facts verification.
-            // TODO: update the current state (component needed).
+            // TODO(#2): reentrancy guard.
+            // TODO(#3): facts verification.
+            // TODO(#4): update the current state (component needed).
 
             // Header size + 2 messages segments len.
             assert(
@@ -86,7 +86,7 @@ mod appchain {
 
             let mut offset = snos_output::HEADER_SIZE;
 
-            // TODO: We should update SNOS output to have the messages count
+            // TODO(#7): We should update SNOS output to have the messages count
             // instead of the messages segment len.
 
             let mut messages_segments = program_output.slice(offset, program_output.len() - offset);

diff --git a/src/config/component.cairo b/src/config/component.cairo
@@ -24,6 +24,7 @@ mod config_cpt {
     #[storage]
     struct Storage {
         /// Appchain operator that is allowed to update the state.
+        // TODO(#9): Multiple Operators
         operator: ContractAddress,
         /// Program info (StarknetOS), with program hash and config hash.
         program_info: (felt252, felt252),
@@ -35,8 +36,7 @@ mod config_cpt {
     impl Config<
         TContractState,
         +HasComponent<TContractState>,
-        impl Ownable: ownable_cpt::HasComponent<TContractState>,
-        +Drop<TContractState>
+        impl Ownable: ownable_cpt::HasComponent<TContractState>
     > of IConfig<ComponentState<TContractState>> {
         fn set_operator(ref self: ComponentState<TContractState>, address: ContractAddress) {
             get_dep_component!(@self, Ownable).assert_only_owner();
@@ -52,6 +52,7 @@ mod config_cpt {
         ) {
             self.assert_only_owner_or_operator();
             self.program_info.write((program_hash, config_hash))
+        // TODO(#6): ProgramHashChanged Event
         }
 
         fn get_program_info(self: @ComponentState<TContractState>) -> (felt252, felt252) {
@@ -73,7 +74,6 @@ mod config_cpt {
         TContractState,
         +HasComponent<TContractState>,
         impl Ownable: ownable_cpt::HasComponent<TContractState>,
-        +Drop<TContractState>
     > of InternalTrait<TContractState> {
         /// Asserts if the caller is the owner of the contract or
         /// the authorized operator. Reverts otherwise.

diff --git a/src/messaging/component.cairo b/src/messaging/component.cairo
@@ -157,7 +157,7 @@ mod messaging_cpt {
 
     #[embeddable_as(MessagingImpl)]
     impl Messaging<
-        TContractState, +HasComponent<TContractState>, +Drop<TContractState>
+        TContractState, +HasComponent<TContractState>
     > of IMessaging<ComponentState<TContractState>> {
         fn send_message_to_appchain(
             ref self: ComponentState<TContractState>,
@@ -284,7 +284,7 @@ mod messaging_cpt {
 
     #[generate_trait]
     impl InternalImpl<
-        TContractState, +HasComponent<TContractState>, +Drop<TContractState>
+        TContractState, +HasComponent<TContractState>
     > of InternalTrait<TContractState> {
         /// Initializes the messaging component.
         ///