feat: remove full state diff deserialization #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`contracts` and `classes` are not used in the state transition process in any way, and do not contribute to output section transversal as they're at the end of the output stream. There's no reason to parse these and immediately discard them.
xJonathanLEI
force-pushed
the
dev/rm_state_diff_deser
branch
from
230039d to
0fe18f4
Compare
glihm
approved these changes
Feb 6, 2025
glihm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contractsandclassesare not used in the state transition process in any way, and do not contribute to output section transversal as they're at the end of the output stream. There's no reason to parse these and immediately discard them.Additionally, Starknet v0.13.3 introduced state diff compression, meaning that the current parsing code is no longer correct - the current implementation cannot settle v0.13.3 blocks.
Instead of spending effort keeping up with all the future state diff compression technique updates, and unnecessarily incurring additional settlement costs, this part should just be removed.
The updated contract has been tested against both v0.13.2.1 and v0.13.3 blocks, with or without L1->L2 and/or L2->L1 messages. All work correctly.