simplify boolean condition

keep-starknet-strange · Nov 2, 2023 · 533f8d2 · 533f8d2
1 parent 29af1ca
commit 533f8d2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/src/oracle/oracle_utils.cairo b/src/oracle/oracle_utils.cairo
@@ -342,15 +342,7 @@ fn revert_oracle_block_number_not_within_range(
 /// # Returns
 /// Wether it's the right error.
 fn is_oracle_error(error_selector: felt252) -> bool {
-    if (is_oracle_block_number_error(error_selector)) {
-        return true;
-    }
-
-    if (is_empty_price_error(error_selector)) {
-        return true;
-    }
-
-    return false;
+    is_oracle_block_number_error(error_selector) || is_empty_price_error(error_selector)
 }
 
 /// Check wether `error` is an EmptyPriceError.

diff --git a/src/utils/arrays.cairo b/src/utils/arrays.cairo
@@ -134,14 +134,10 @@ fn are_lte(mut arr: Span<u128>, value: u128) -> bool {
 fn are_lte_u64(mut arr: Span<u64>, value: u64) -> bool {
     loop {
         match arr.pop_front() {
-            Option::Some(item) => {
-                if *item > value {
-                    break false;
-                }
-            },
-            Option::None => {
-                break true;
-            },
+            Option::Some(item) => { if *item > value {
+                break false;
+            } },
+            Option::None => { break true; },
         };
     }
 }