-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: implement-apply_exponent_factor-function-in-precision #456
Merged
zarboq
merged 37 commits into
keep-starknet-strange:main
from
StarkFishinator:Feat--implement-apply_exponent_factor-function-in-precision
Nov 5, 2023
Merged
Feat: implement-apply_exponent_factor-function-in-precision #456
zarboq
merged 37 commits into
keep-starknet-strange:main
from
StarkFishinator:Feat--implement-apply_exponent_factor-function-in-precision
Nov 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarkFishinator
changed the title
exp function, no tested (failed setting up runner)
Feat -- implement-apply_exponent_factor-function-in-precision
Sep 29, 2023
StarkFishinator
changed the title
Feat -- implement-apply_exponent_factor-function-in-precision
Feat: implement-apply_exponent_factor-function-in-precision
Sep 29, 2023
…t-strange#3 (keep-starknet-strange#463) * 10 functions done * almost finished, debug next * debug time * debuging * pushing recent changes/ still bug because missing functions * debuging finished * adding comments on functions * almost clean * Emit bug * programm compile 🎉 * resolving last test * All test passed * resolve request * 1 test failed because of max swap path lenght exceed test * resolving failed test * resolve * solving * compilation resolved --------- Co-authored-by: Michel <[email protected]>
* test(deposit_vault_contract): Can start doing some unit tests from that * test(deposit_vault_contract): Better format * test(deposit_vault_contract): All test passes! 🥳 * test(deposit_vault_contract): Added unit test for transfer_out not enough balance --------- Co-authored-by: akhercha <[email protected]> Co-authored-by: sparqet <[email protected]>
…exponent_factor-function-in-precision
2 tasks
…nge#499) * test(referral_storage_contract): Refacto test architecture before adding tests * test(referral_storage_contract): Quick refacto of base tests * test(referral_storage_contract): Added more tests * test(referral_storage_contract): Finished tests for referral_storage contract * test(referral_storage_contract): Removed custom teardown * test(referral_storage_contract): Unused imports * test(referral_storage_contract): Updated top comment * test(referral_storage_contract): from review; added init check in Governable * test(referral_storage_contract): Removed useless line * test(referral_storage_contract): Removed useless line x2 💀 --------- Co-authored-by: akhercha <[email protected]>
(keep-starknet-strange#498) * update referalla-util tests * allow changing refferal * remove role_store --------- Co-authored-by: zarboq <[email protected]>
* strict bank start * strict bank contract and tests * All strict bank tests running * formatted --------- Co-authored-by: Michel <[email protected]> Co-authored-by: sparqet <[email protected]> Co-authored-by: zarboq <[email protected]>
* ✨ execute_deposit_utils fn * fix: clone fees and rm extra line * fix: prevent BadMergeBaseMismatch by adding else to if- * fix: fmt issue
* 10 functions done * almost finished, debug next * debug time * debuging * pushing recent changes/ still bug because missing functions * debuging finished * adding comments on functions * almost clean * Emit bug * programm compile 🎉 * resolving last test * All test passed * resolve request * 1 test failed because of max swap path lenght exceed test * resolving failed test * resolve * solving * compilation resolved * Added as a Contributor * Adding profil on ReadMe --------- Co-authored-by: Michel <[email protected]>
* test(record_transfer_in_function): Added unit tests for record_transfer_in * test(record_transfer_in_function): Added unit tests * test(record_transfer_in_function): Better error message * test(record_transfer_in_function): Mock + Overflow prevented * test(record_transfer_in_function): Removed useless import * test(record_transfer_in_function): record_transfer_in panic on sub overflow * test(record_transfer_in_function): Quick test refacto * test(record_transfer_in_function): Unused variables in tests --------- Co-authored-by: akhercha <[email protected]> Co-authored-by: zarboq <[email protected]>
* add test to gov * fmt fix
…exponent_factor-function-in-precision
…exponent_factor-function-in-precision
zarboq
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #417
What is the new behavior?
Implement PRB Math library.
Does this introduce a breaking change?
No