Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use indexes for LogData #539

Merged
merged 44 commits into from
Nov 1, 2023
Merged

feat: Use indexes for LogData #539

merged 44 commits into from
Nov 1, 2023

Conversation

akhercha
Copy link
Contributor

@akhercha akhercha commented Oct 18, 2023 •
edited
Loading

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature

What is the current behavior?

Resolves: #537

What is the new behavior?

  • Added SerializableFelt252Dict struct & its unit tests
  • Replaced LogData members & functions with SerializableFelt252Dict & added tests
  • Replaced places where LogData is used/created to align with those changes

Does this introduce a breaking change?

No

Sk8erboi84
Sk8erboi84 reviewed Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Sk8erboi84 Sk8erboi84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill take a look into that PR

akhercha added 15 commits October 25, 2023 09:02
@akhercha
feat(log_data_indexes): Renamed structs + address_items impl
b09d65b
@akhercha
feat(log_data_indexes): Generic impl
9999822
@akhercha
feat(log_data_indexes): fmt
61185c2
@akhercha
feat(log_data_indexes): Trigger CI to check semgrep
cd89257
@akhercha
Merge branch 'main' into feat/log_data_indexes
43ea52d
@akhercha
feat(log_data_indexes): Renaming + Started unit tests
728c5dc
@akhercha
Merge branch 'feat/log_data_indexes' of github.com:akhercha/satoru in…
83d5b29 
…to feat/log_data_indexes
@akhercha
feat(log_data_indexes): Merge
38d5c81
@akhercha
feat(log_data_indexes): Update SerializableDict with custom i128
15daea3
@akhercha
feat(log_data_indexes): Checkpoint; units break
5e72d6c
@akhercha
feat(log_data_indexes): Replaced SerializableDict's Array by Span
a81153c
@akhercha
feat(log_data_indexes): Utilities fn
4af231e
@akhercha
feat(log_data_indexes): Adding unit tests for debug
74850d1
@akhercha
feat(log_data_indexes): TODO: investigate serialization fail
b3b71cd
@akhercha
feat(log_data_indexes): update
ffd003d
@akhercha akhercha mentioned this pull request Oct 28, 2023
Closed
@akhercha akhercha marked this pull request as ready for review October 30, 2023 20:58
@akhercha akhercha requested a review from AbdelStark as a code owner October 30, 2023 20:58
@akhercha
Copy link
Contributor Author

Ready for a review! @Sk8erboi84

@akhercha akhercha requested a review from Sk8erboi84 November 1, 2023 08:45
zarboq
zarboq approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@zarboq zarboq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !

@Sk8erboi84 Sk8erboi84 merged commit 282539e into keep-starknet-strange:main Nov 1, 2023
@akhercha akhercha deleted the feat/log_data_indexes branch November 1, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sk8erboi84 Sk8erboi84 Sk8erboi84 approved these changes

@zarboq zarboq zarboq approved these changes

@AbdelStark AbdelStark Awaiting requested review from AbdelStark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Implement an add with index for LogData
3 participants
@akhercha @zarboq @Sk8erboi84