-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 14 unit tests to test_reader.cairo
#561
Conversation
test_reader.cairo
test_reader.cairo
@sparqet i look forward to hearing from you |
@sparqet could you at this and provide some feedback ? 😄 |
ISSUES
These 2 recently stopped working In Summary 7 added tests passed, 2 returns 0x0 value 1 returns a due process error and 2 failed returning a panicked error (i’ve commented them in the code base) |
hi @sparqet , @abdelhamidbakhta , @Sk8erboi84 with reference to this issue #491 i added 14 tests cases in the
test_reader.cairo
, 9 are working as expected but 5 are not. thefn get_pnl_to_pool_factor
returns 0x0,fn get_virtual_inventory
also returns 0x0,get_swap_amount_out
&get_adl_state
returns an unwrap failed error andget_swap_price_impact
returns a panicked crates error. i've tagged the functions with @Audit tag in thetest_reader.cairo
file. I'm already looking to the reasons for the errors, but that would mean major changes to the code base. Any suggestions or perhaps am i missing something?.