Testing - First PR for issue #476 #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, on it now. |
|
done, kindly check and review |
zarboq
requested changes
Nov 2, 2023
tests/adl/test_adl_utils.cairo
Outdated
| size_delta_usd: 0, | ||
| updated_at_block: 100 | ||
| }; | ||
| adl_utils::create_adl_order(params); |
There was a problem hiding this comment.
Could you check that adl_order is stored in the data_store and that you can retrieve it
tests/adl/test_adl_utils.cairo
Outdated
| size_delta_usd: 0, | ||
| updated_at_block: 100 | ||
| }; | ||
| adl_utils::create_adl_order(params); |
There was a problem hiding this comment.
Suggested change
| adl_utils::create_adl_order(params); | |
| let key = adl_utils::create_adl_order(params); | |
| // Assertions | |
| let order = data_store.get_order(key); | |
| assert(order.account == account1, 'wrong order'); | |
| assert(order.order_type == OrderType::MarketDecrease(()), 'wrong type'); | |
| assert(order.updated_at_block == 100, 'wrong updated'); |
There was a problem hiding this comment.
alright, fixing that now, is that all the changes that's needed.
zarboq
approved these changes
Nov 3, 2023
|
hi @zarboq , i synced the fork and realized it closed the pr, so sorry about that, here's the link to the new pr with all conflicts resolved, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Other information